add missing concrete implementation of abstract class #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lutter#93448) * Added SharedAppData to the widgets library (flutter#93175) * 'add branch flutter-2.8-candidate.3 to enabled_branches in .ci.yaml' * 'Update Engine revision to 09f1520 for beta release 2.8.0-3.1.pre' * Pin to specific plugin version in multidex test (flutter#93148) Co-authored-by: Hans Muller <[email protected]> Co-authored-by: Emmanuel Garcia <[email protected]>
…lutter#93841) * [flutter_tools] Catch lack of flutter tools source missing (flutter#93168) * 'Update Engine revision to bcc2b7f for beta release 2.8.0-3.2.pre' * Replace text directionality control characters with escape sequences in the semantics_tester (flutter#93034) Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: Jason Simmons <[email protected]>
…lutter#94490) * make CIPD url customizable using FLUTTER_STORAGE_BASE_URL (flutter#94137) * 'Update Engine revision to 06a7363 for beta release 2.8.0-3.3.pre' * Update plugin lint test for federated url_launcher plugin (flutter#94374) Co-authored-by: Yegor <[email protected]> Co-authored-by: Jenn Magder <[email protected]>
* Update configurations to match the current test beds. * Update cirrus secrets. * Disable mac_module_test_ios. The fix for the test not available in this branch.
…r#95375) * Build Flutter iOS plugins with all valid architectures (flutter#95293) * 'add branch flutter-2.8-candidate.3 to enabled_branches in .ci.yaml' * 'Update Engine revision to 890a5fca2e34db413be624fc83aeea8e61d42ce6 for stable release 2.8.1' Co-authored-by: Jenn Magder <[email protected]>
…lutter#93448) * Added SharedAppData to the widgets library (flutter#93175) * 'add branch flutter-2.8-candidate.3 to enabled_branches in .ci.yaml' * 'Update Engine revision to 09f1520 for beta release 2.8.0-3.1.pre' * Pin to specific plugin version in multidex test (flutter#93148) Co-authored-by: Hans Muller <[email protected]> Co-authored-by: Emmanuel Garcia <[email protected]>
…lutter#93841) * [flutter_tools] Catch lack of flutter tools source missing (flutter#93168) * 'Update Engine revision to bcc2b7f for beta release 2.8.0-3.2.pre' * Replace text directionality control characters with escape sequences in the semantics_tester (flutter#93034) Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: Jason Simmons <[email protected]>
…lutter#94490) * make CIPD url customizable using FLUTTER_STORAGE_BASE_URL (flutter#94137) * 'Update Engine revision to 06a7363 for beta release 2.8.0-3.3.pre' * Update plugin lint test for federated url_launcher plugin (flutter#94374) Co-authored-by: Yegor <[email protected]> Co-authored-by: Jenn Magder <[email protected]>
…mimes Zach/commit mimes
|
Hey, I assume this is whatever was in the upstream's master? Just want to make sure. Also, can you resolve conflicts? Thanks! |
…-master Flutter Master
|
correct. After my initial commit/PR to add to the test files, I just did a "git pull upstream", "git push origin", and then resolved all the conflicts. It just seemed to all all of that to the existing PR rather than create a 2nd one. Its weird, I am not seeing any conflicts in my repo. Can you tell me what file you are seeing conflicts in? |
|
@zlshames sorry, conflicts should be fixed now. |
…ch/flutter-master Revert "Flutter Master"
…ch/commit-mimes Revert "Zach/commit mimes"
|
@googlebot I consent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add missing concrete implementation of abstract class
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.