Use pickle in a pandas 2.x compatible way #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going by pandas-dev/pandas#53300 this should be backwards compatible with older versions of pandas down to 0.20.3.
|
Thank you very much for this improvement. BBP engineers have not found the time to ensure that the simulation toolchain using AstroVascPy is working with pandas 2x. Your proposal will be a huge plus. |
tristan0x
approved these changes
May 24, 2024
There was a problem hiding this comment.
Nothing prevents us from using pandas 2.x
Preliminary tests on our internal simulation toolchain are ✅
Thank you @penguinpee for this improvement
|
Gosh. You scared me there for a bit. I thought where has my weekend gone... 😜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going by pandas-dev/pandas#53300 this should
be backwards compatible with older versions of pandas down to 0.20.3.