Globally sync Water Wheel rotation #5032
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syncs all waterwheels rotation depending on gameTime and turning speed has grace period, so players changing the wheel speed by altering the liquid flow don't look at janky animation jumps
"Adding the check to the tick method definitly isn't the solution" -malte
after the grace period transitions smoothly into the synced state instead of snapping to it
MalkContent
force-pushed
the
globalSyncWaterWheels
branch
from
1706c92
to
58891dd
Compare
|
if you've got the time, check out the new smooth transition into the synced state |
|
also: the huge list of commits makes me think that the rebasing didn't go as planned, at least on the remote side.. |
|
You're trying to merge into 1.17, so it's including all the commits since then. Change the target branch for the PR? |
|
ty for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synchronizes all waterwheels that are going at the same speed by setting their
rotationtolevel.getGameTime()*perTick % 1changing
perTickby changing the waterflow starts a grace period where the rotation is not synced to the game time so players still perceive smooth transitions in waterwheel speed/rotation instead of janky jumping of the wheel. after the grace period the wheel makes a single jump, hopefully when noone is looking anymore.