Skip to content

Commit

Permalink
getblocks retry 5 times on 'Block not found on disk'
Browse files Browse the repository at this point in the history
  • Loading branch information
RCasatta committed Sep 30, 2024
1 parent 6d182d8 commit 19e084f
Showing 1 changed file with 25 additions and 1 deletion.
26 changes: 25 additions & 1 deletion src/daemon.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ lazy_static! {
);
}

const MAX_ATTEMPTS: u32 = 5;
const RETRY_WAIT_DURATION: Duration = Duration::from_secs(1);

fn parse_hash<T>(value: &Value) -> Result<T>
where
T: FromStr,
Expand Down Expand Up @@ -495,7 +498,28 @@ impl Daemon {
.iter()
.map(|hash| json!([hash, /*verbose=*/ false]))
.collect();
let values = self.requests("getblock", &params_list)?;

let mut attempts = MAX_ATTEMPTS;
let values = loop {
attempts -= 1;

match self.requests("getblock", &params_list) {
Ok(blocks) => break blocks,
Err(e) => {
let err_msg = format!("{e:?}");
if err_msg.contains("Block not found on disk") {
// There is a small chance the node returns the header but didn't finish to index the block
log::warn!("getblocks failing with: {e:?} trying {attempts} more time")
} else {
panic!("failed to get blocks from bitcoind: {}", err_msg);
}
}
}
if attempts == 0 {
panic!("failed to get blocks from bitcoind")
}
std::thread::sleep(RETRY_WAIT_DURATION);
};
let mut blocks = vec![];
for value in values {
blocks.push(block_from_value(value)?);
Expand Down

0 comments on commit 19e084f

Please sign in to comment.