Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): replace server-side api calls with client-side for list pages #298

Open
wants to merge 6 commits into
base: feature/contract
Choose a base branch
from

Conversation

lykalabrada
Copy link
Contributor

@lykalabrada lykalabrada commented Jul 20, 2023

What this PR does / why we need it:

[tl;dr]
The main difference is: The UI loaders will display faster but essentially the amount of time for the data to display is the same.

In the current meta.defiscan.live, most of our API calls are done from the server side which is causing initial load to be slow and page switching to be clunky.
In this PR most API calls have been moved to the client side, this would allow our pages to be rendered right away before calling the APIs

on initial load, page is displayed right away, but users will see custom loaders for specific section (where api is not yet finished)
when switching page, users will see the loader right away instead of being stuck on the current page

Which issue(s) does this PR fixes?:

Fixes DFC-136

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*

@linear
Copy link

linear bot commented Jul 20, 2023

DFC-119 Task: UI/UX Improvement - Tool tips

What UI/UX improvements need to be implemented?

More information for tool tips

Why is this needed?

Users don't understand what it means

Which component/screens does this concern?

DMC Explorer---Exploration-File (Figma)

@linear
Copy link

linear bot commented Jul 20, 2023

DFC-136 Performance: Improve speed of page redirects

[tl;dr]
The main difference is: The UI loaders will display faster but essentially the amount of time for the data to display is the same.

In the current meta.defiscan.live, most of our API calls are done from the server side which is causing initial load to be slow and page switching to be clunky.
In this PR most API calls have been moved to the client side, this would allow our pages to be rendered right away before calling the APIs

  • on initial load, page is displayed right away, but users will see custom loaders for specific section (where api is not yet finished)
    • Steps to reproduce: Open metascan on incognito mode, notice how long it takes to load the entire page
  • when switching page, users will see the loader right away instead of being stuck on the current page
    • Steps to reproduce: From Home page > Navigate "Transactions" list > Navigate to "Blocks" list

@lykalabrada lykalabrada changed the title Lyka/client side api calls feat(core): replace server-side api calls with client-side for list pages Jul 20, 2023
@github-actions github-actions bot added the kind/feature New feature request label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant