Only reset network when settings change

BinghamtonRover · Nov 22, 2024 · ee0ba06 · ee0ba06
1 parent 8cb5bff
commit ee0ba06
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/lib/src/models/view/builders/settings_builder.dart b/lib/src/models/view/builders/settings_builder.dart
@@ -1,3 +1,4 @@
+import "package:collection/collection.dart";
 import "package:flutter/material.dart";
 import "package:rover_dashboard/data.dart";
 import "package:rover_dashboard/models.dart";
@@ -377,8 +378,14 @@ class SettingsBuilder extends ValueBuilder<Settings> {
       // Need an if to avoid resetting throttle when trying to set throttle
       models.rover.setDefaultControls();
     }
+    final resetSockets = !(const DeepCollectionEquality().equals(
+      models.settings.network.toJson(),
+      value.network.toJson(),
+    ));
 		await models.settings.update(value);
-		await models.sockets.reset();
+    if (resetSockets && models.sockets.isEnabled) {
+      await models.sockets.reset();
+    }
 		models.video.reset();
 		isLoading = false;
 		notifyListeners();