Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add support for Python 3.12 #7

wants to merge 3 commits into from

Conversation

BillSchumacher
Copy link
Owner

@BillSchumacher BillSchumacher commented Oct 28, 2024

Summary by Sourcery

CI:

  • Add Python 3.12 to the CI testing matrix in the GitHub workflow for Django.

Copy link

sourcery-ai bot commented Oct 28, 2024

Reviewer's Guide by Sourcery

This PR adds Python 3.12 support to the test matrix in the GitHub Actions workflow. The change is straightforward, simply adding Python 3.12 as a new version to be tested against various Django versions and database adapters.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added Python 3.12 to the CI test matrix
  • Added Python 3.12 to the list of Python versions in the test matrix
  • Maintains existing test combinations with Django versions and psycopg variants
.github/workflows/django.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BillSchumacher - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please verify Django's Python 3.12 compatibility matrix and add appropriate exclusions for any unsupported Django versions to prevent known-failing test combinations.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@BillSchumacher
Copy link
Owner Author

Unfortunately it appears the django-pgtrigger has some incompatibilities hopefully fixed by my PR or another solution: AmbitionEng/django-pgtrigger#180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant