Let ItemsAdder be a new OneBlockCustomBlock #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HSGamer I'm okay with merging this, but I don't understand what it does exactly to answer your questions. Could you tell me more? |
Should I do:
|
|
Let's go for option 1! I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moved the ItemsAdder to a new
OneBlockCustomBlock.It bugs me that ItemsAdder is treated differently, although we already have
CustomBlock. So this is to prove a point that something that supports ItemsAdder can be either a newCustomBlockor a new Addon.P/S: Should I just remove the ItemsAdder code and create a new Addon, or just make a new
CustomBlock?