-
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nanite active program conversion, rebalancing & additions #11827
base: master
Are you sure you want to change the base?
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I have a hunch that not all those 210 file changes are intended. |
Yea, merging the trait changes into my older branch broke it. Its an easy fix |
961ddc8
to
adb360e
Compare
Update trait_tests.dm Update trait_tests.dm Deletes properties Fixes some bugs with traits and heaps Update trait_tests.dm Get heap values Fixes a bug caused by a byond issue Update _traits.dm priority trait value test Adds more trait tests Adds support for trait not in Update _traits.dm Update _traits.dm Update _traits.dm Update _traits.dm Update _traits.dm Fixes remove in and remove not in Mutant bodyparts Update _traits.dm Update trait_tests.dm Update _traits.dm Update _traits.dm Absolute path conversion Co-Authored-By: EvilDragonfiend <[email protected]> Adds the traits to the trait declaration file Update heap.dm Heavy optimisations Update heap.dm Update heap.dm Further performance improvements Fixes traits for non string sources Update _traits.dm Update _traits.dm Spelling mistake fix Removes linting for the static control flow term Fixes some linting issues Update heap.dm Adds open dream trait support Update _traits.dm Update _traits.dm Update _traits.dm Update heap.dm Update _traits.dm Update _traits.dm Tries to fix opendream Update _traits.dm Update _traits.dm Update _traits.dm Update _traits.dm Update _traits.dm Update _traits.dm Update _traits.dm Update _traits.dm Update _traits.dm Update _traits.dm Seperates value traits and normal traits to appease OD Update trait_tests.dm Update _traits.dm Fixes a mix up with variable naming Cleans up the code
Balance-wise these look much better, although this might be enough of a nerf that nanites largely stop being used. They're still worthwhile but they will rarely be single-handedly deciding battles now, which is a much better spot for them to be. I'm not familiar enough with the all of the code touched to give a full approval this time though. |
About The Pull Request
Why It's Good For The Game
Nanites are hard to balance by use rate, so let's balance them with a well known and easy to understand metric instead, time.
Testing Photographs and Procedure
Forced speech sensor
Changelog
🆑
add: Nanites now support active abilities, which last for a set amount of time before needing to cooldown (Instead of lasting until the nanites in the mob run out).
tweak: Simplifies trigger nanites to make them easier to understand and work with.
add: Adds nanite tomb, a nanite program which temporarilly prevents death.
add: Adds bleeding sensor, a nanite program which detects if the user is currently bleeding.
add: Adds pressure sensor, a nanite program for sensing the pressure.
add: Continuous sensor nanites can now be set to send a code when they stop detecting the conditions.
del: Removes advanced healing nanites.
balance: Converts a large number of passive nanites into active nanites, which require triggering to activate and have a set duration and cooldown.
/:cl: