fix(golang): permissive regex rule for validation purposes #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ideally the
go_lang_permissive_regex_validation
rule would only trigger when the permissive regular expression is being used for validation-specific purposes. Unlike some frameworks (Ruby-on-Rails, PHP Symfony), with golang, we cannot determine how a particular regular expression is being used. For this reason, the rule was triggering on the compilation of permissive regex, rather than its use. However, this meant that we were seeing some confusing false positives with this rule -- for example, withReplace
(where there is no real security issue).To address this, we modify the rule so that it triggers only when a permissive regular expression is used with
Match
methods, as this is more likely to be a validation case. We hope that this will reduce the rate of false positives while still proving useful in alerting users to actual security issues.Checklist
If this is your first time contributing please sign the CLA