aggregated a number of PRs, this now lives in ru-add-gdp, should land in main #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch/cities into nl-add-transportation-spendings
…ings Cleaning spending datasets from us spending
Added population and generalized data loading and euclidean distances to multiple features
riadas
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Looks good to me -- I agree with Andy's comments related to storing data in a DB rather than .csv files and some other refactors for readability in the long-term, but think those can be resolved in the future (e.g. after the TOP sprint) given current time constraints and priorities. From my perspective, I've been importing the cities package from this branch into the BasisResearch/cities-app repository and it has been working well enough, so will merge to get main up-to-date. I'll make new issues out of the importing-cities-in-other-projects bugs I've come across.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22 .
Quite a few different PRs are now aggregated in ru-add-gdp, which is way ahead of main, please merge into main if no further comments, as there is also a line up of PRs with new features.
@riadas As all tests succeed locally, investigate and revise the GitHub automated testing workflow prior to merging.