-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This is probably okay (tests pass, semver lines up), but only surfaced by my ill-fated attempt to squelch an irrelevant Dependabot finding in #263. |
I've put up #265 to remove the dependency instead of updating it. I'm good with either approach, with a slight bias to removing it for now since it's not really necessary |
Does another dependency transitively pull in a safe version? I haven't done the legwork. I prefer #265 if Dependabot likes it. |
Oh I thought the requirement of a particular "safe" version wasn't necessary b/c the dependabot alert had to be closed anyway. Maybe I misunderstood though |
Oh, no, you're right. I thought it was some long-established override and didn't connect the dots to my own comment three days ago. These things become a blur once there are enough of them... |
And after that discussion ... there's a new one on the same dependency. |
lol okay, let's just merge this one then π |
For whatever reason, it still didn't work to close the alert. There's some nuance I've missed. |
This feels like a problem with the security alert? The spring page is pretty clear that 1.1.13 is fixed: https://spring.io/security/cve-2023-34054 |
When I pulled the report on the prior PR, both a vulnerable version and the latest version were being submitted to GitHub. This library is transitive via another dependency, but ... we do that all the time! I couldn't quickly figure out what was different here. |
What's different is typelevel/sbt-typelevel#671. The config in sbt-typelevel differs from most of our internal projects. The vulnerable dependency is being reported in |
About this PR
π¦ Updates io.projectreactor.netty:reactor-netty-http from
1.0.39
to1.1.13
π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: