This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
Use fs2 flow interop #254
Merged
Use fs2 flow interop #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterneyens
force-pushed
the
fs2-flow-interop
branch
from
769f2f0 to
2e00df0
Compare
|
The project currently requires Java 8, and I believe these types were introduced in Java 9. I think we would need to bump the build to Java 11. |
|
I didn't realize we were still including java 8. |
|
On most projects, I keep 8 until it hurts. Now it hurts, and people have had 5 years to get to at least 11. I think bumping to 11 is fine. |
rossabaker
approved these changes
Oct 30, 2023
megankelly
approved these changes
Oct 30, 2023
vendamere
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs2-reactive-streamshas been replaced by the interop with java 9Flow.