Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GD Image renderer #159

Closed
wants to merge 18 commits into from
Closed

Conversation

arxeiss
Copy link
Contributor

@arxeiss arxeiss commented Mar 18, 2024

Copy of closed #114


My client's web hosting provider sucks, and they don't have support for Imagick, even though they are promising it will be added.

I'm generating QR codes for payment, which is added into email body. And email client's do not have nice support for SVG. So I need old-school GD support.

However, GD has limited sets of functions. I believe, that it is OK, when that Renderer will have also limited sets of features.
So this is not supported:

  • Any roundness like DotsModule, RoundnessModule or SimpleCircleEye
  • Gradients

And because GD does not support Paths like Imagick or SVG do, I need to generate a bit different paths, so they are not so complex.


Sorry for opening new PR, but I had to change branch. I really needed the GD Renderer and in many projects I'm using this in package.json. Not to break them by changing commit name, I had to create new branch. But then it is not possible to change source branch in PR.

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/arxeiss/BaconQrCode"
        }
    ],
    "require": {
        "php": "^8.2",
        "bacon/bacon-qr-code": "dev-add-gd-backend#650e10121f4d8707ecdc5984b042cae7731e388a",

williamdes and others added 18 commits December 7, 2022 11:41
Debian adjustments and project improvements
allow PHPUnit 10/11,
allow "spatie/phpunit-snapshot-assertions" 5
…action

chore: bump github action "codecov/codecov-action" 3 => 4
* Non-locale aware of scale and translate
* Fix lint warning - too long line
@arxeiss arxeiss mentioned this pull request Mar 18, 2024
@DASPRiD
Copy link
Member

DASPRiD commented Mar 19, 2024

LGTM! Would you mind adding a short section in the README about this alternative renderer?

@DASPRiD
Copy link
Member

DASPRiD commented Mar 19, 2024

Please rebase against new main branch, had to do some maintenance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.