Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in version 4 #143

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Bug in version 4 #143

merged 1 commit into from
Sep 5, 2023

Conversation

alien999999999
Copy link
Contributor

nr of blocks is wrong, it doesn't match the size of the version

@alien999999999
Bug in version 4
da917b4 
nr of blocks is wrong, it doesn't match the size of the version
@DASPRiD
Copy link
Member

DASPRiD commented Sep 5, 2023

Thanks, I just matched that up against ZXing, you are correct, thanks!

https://github.com/zxing/zxing/blob/557b5fcf0e22a6cf2541a54bd830116712fec51d/core/src/main/java/com/google/zxing/qrcode/decoder/Version.java#L264

@DASPRiD DASPRiD added the bug label Sep 5, 2023
@DASPRiD DASPRiD requested review from DASPRiD and removed request for DASPRiD September 5, 2023 16:30
@DASPRiD DASPRiD merged commit ed3734a into Bacon:master Sep 5, 2023
5 checks passed
@alien999999999
Copy link
Contributor Author

Oh, ok. I didn't know, i just noticed it didn't match the total from the other ecblocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alien999999999 @DASPRiD