Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LegalEntitySaga: fix periodic limits bounds setQuarterly #484

Conversation

jubr
Copy link
Contributor

@jubr jubr commented Nov 12, 2024

Description

In the LegalEntitySagas the method periodicLimits() that collects PeriodicLimitsBounds had a minor typo where for getQuarterly it would overwite the setDaily value.

Checklist

  • I made sure, I read CONTRIBUTING.md to put right branch prefix as per my need.
  • I made sure to update CHANGELOG.md. ~ will do when accepted by means of comment
  • I made sure to update Stream Wiki(only valid in case of new stream module or architecture changes). ~ N/A
  • My changes are adequately tested.
  • I made sure all the SonarCloud Quality Gate are passed. ~ lets see what Github actions say, I'm optimistic :p

@jubr jubr requested a review from a team as a code owner November 12, 2024 20:17
@jubr jubr force-pushed the hotfix/legal-entity-core-sagas-limits-bounds-quarterly branch from a8f5b13 to 32312c6 Compare November 27, 2024 15:37
@jubr jubr force-pushed the hotfix/legal-entity-core-sagas-limits-bounds-quarterly branch from 32312c6 to 0cfa68b Compare December 10, 2024 20:54
@uesleilima uesleilima merged commit 908b14b into Backbase:master Dec 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants