Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transaction-cursor: fix dependency issue - fix local config #384

Merged
merged 3 commits into from
Nov 3, 2023
Merged

transaction-cursor: fix dependency issue - fix local config #384

merged 3 commits into from
Nov 3, 2023

Conversation

BB-ASehmi
Copy link
Contributor

Description

With the change to use spring-cloud-starter-kubernetes-fabric8, we needed to also add the service-sdk-starter-mapping dependency to transaction-cursor.

Checklist

  • [ x] I made sure, I read CONTRIBUTING.md to put right branch prefix as per my need.
  • [ x] I made sure to update CHANGELOG.md.
  • [ N/A] I made sure to update Stream Wiki(only valid in case of new stream module or architecture changes).
  • [x ] My changes are adequately tested.
  • [x ] I made sure all the SonarCloud Quality Gate are passed.

@BB-ASehmi BB-ASehmi requested a review from a team as a code owner November 2, 2023 19:22
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BB-ASehmi BB-ASehmi merged commit 7cebabe into master Nov 3, 2023
4 checks passed
@BB-ASehmi BB-ASehmi deleted the feature/txn-cursor-dependency-fix branch November 3, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafiquech shafiquech shafiquech approved these changes

@uesleilima uesleilima uesleilima approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BB-ASehmi @uesleilima @shafiquech