-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/custom card journey #16
Open
BhargaviYamanuri
wants to merge
19
commits into
main
Choose a base branch
from
feature/custom_card_journey
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BhargaviYamanuri
commented
Feb 15, 2024
- Created Custom card journey with MVI architecture.
- It will give understanding of how to crate a journey.
- We used modular concept.
# Conflicts: # app/src/main/assets/backbase/config.json # app/src/main/res/navigation/navigation_main.xml
# Conflicts: # accounts-journey/src/main/kotlin/com/backbase/accounts_journey/presentation/accountlist/ui/AccountListFragment.kt # app/src/main/kotlin/com/backbase/golden_sample_app/MainApplication.kt # settings.gradle.kts
# Conflicts: # accounts-journey/src/main/kotlin/com/backbase/accounts_journey/presentation/accountlist/ui/AccountListFragment.kt # accounts-journey/src/main/res/navigation/account_journey_nav_graph.xml # accounts-journey/src/main/res/values/strings.xml # app/build.gradle.kts # app/src/main/kotlin/com/backbase/golden_sample_app/MainApplication.kt # app/src/main/res/navigation/navigation_main.xml # gradle/backbase.versions.toml # settings.gradle.kts
ran detekt
Ran detekt, applied format
I checked and merged 2024.09.LTS into this branch. If this is going to be part of the main branch, we need new gradle modules to separate RnD and CS. Now Core-UI module is on the root and use by CS journey. This might be confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.