Allow for creating a zero size plane

[amirt-ms]

I have a use case for creating a plane with zero width/height and then updating it live. The current method of checking whether a size/width/height is passed does not allow this. These changes check if the value is defined instead of is truthy.

[bjsplat]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[bjsplat]

Snapshot stored with reference name:
refs/pull/16052/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16052/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16052/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16052/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16052/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16052/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16052/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16052/merge#BCU1XR#0

[bjsplat]

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16052/merge/testResults/webgl2playwright/index.html

[bjsplat]

Visualization tests for WebGPU (Experimental)

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16052/merge/testResults/webgpuplaywright/index.html

[sebavan]

This is a breaking change and I am not sure to understand why it is usefull if you update the values ?

[amirt-ms]

This is a breaking change and I am not sure to understand why it is usefull if you update the values ?

Can you please explain what this breaks?

I want to construct a plane of zero size. I cannot do this in the current implementation because 0 is falsy, so the code defaults to a size of 1, even though I passed size as an argument. In my opinion, this is a bug.

[deltakosh]

It is a breaking change because users (like in NGE) can assume 0 as "default":

Babylon.js/packages/dev/core/src/Meshes/Node/Blocks/Sources/planeBlock.ts

Line 125 in 40902f0

options.size = this.size.getConnectedValue(state);

[deltakosh]

We have two ways here:

• We can have a special case where if size === -1, then we construct it with size = 0. Fishy but compatible
• We break compat, update NGE and only use undefined for real undefined values

[deltakosh]

Actually option 2 is fine. THe CreatePlaneVertexData is not used by nge

You can go ahead with just that slight change: there is no need to use typeof, simply check option.width !== undefined

[amirt-ms]

Actually option 2 is fine. THe CreatePlaneVertexData is not used by nge

You can go ahead with just that slight change: there is no need to use typeof, simply check option.width !== undefined

Thank you for this information; I made this change here: 45d9bbc. Please let me know if any further changes should be made.