md5 the cache key so it doens’t get bigger than 100

Babacooll · May 23, 2017 · c29440e · c29440e
1 parent 3142bff
commit c29440e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/LoLApi/Api/BaseApi.php b/src/LoLApi/Api/BaseApi.php
@@ -40,8 +40,8 @@ protected function callApiUrl($url, array $queryParameters = [])
         $queryParameters = array_merge(['api_key' => $this->apiClient->getApiKey()], $queryParameters);
         $fullUrl         = $this->buildUri($url, $queryParameters);
 
-        if ($this->apiClient->getCacheProvider()->contains($fullUrl)) {
-            return $this->buildApiResult($fullUrl, json_decode($this->apiClient->getCacheProvider()->fetch($fullUrl), true), true);
+        if ($this->apiClient->getCacheProvider()->contains(md5($fullUrl))) {
+            return $this->buildApiResult($fullUrl, json_decode($this->apiClient->getCacheProvider()->fetch(md5($fullUrl)), true), true);
         }
 
         try {

diff --git a/src/LoLApi/ApiClient.php b/src/LoLApi/ApiClient.php
@@ -260,6 +260,6 @@ public function getBaseUrl()
      */
     public function cacheApiResult(ApiResult $apiResult, $ttl = 60)
     {
-        $this->cacheProvider->save($apiResult->getUrl(), json_encode($apiResult->getResult()), $ttl);
+        $this->cacheProvider->save(md5($apiResult->getUrl()), json_encode($apiResult->getResult()), $ttl);
     }
 }