Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove slash from api_url #219

Merged
merged 3 commits into from
Nov 7, 2024
Merged

fix: Remove slash from api_url #219

merged 3 commits into from
Nov 7, 2024

Conversation

YolanFery
Copy link
Contributor

When pushing a pipeline using the SDK, I was getting http://localhost:8000//workspaces/test/pipelines/simple-etl which contains an extra slash. This PR fixes the issue, adds a unit test to cover the change and some parts of pipelines_push method.

Changes

  • Strip the slash in the url method
  • Reuse the api_url method to compute the public api url
  • Add a unit test to cover the push method
  • Refactor the unit tests to avoid duplication of code and constants
  • Add the Pr template from other repos

How/what to test

  • Pushing a pipeline works with and without slash at the end of the config url
  • Unit test are still passing

@YolanFery YolanFery self-assigned this Nov 6, 2024
.gitignore Outdated Show resolved Hide resolved
@qgerome qgerome merged commit 965ba0b into main Nov 7, 2024
4 checks passed
@qgerome qgerome deleted the fix/yolan/pipeline_push branch November 7, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants