add industry domain and preferred branches to the station model and their search filters #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… search filters for them
pratham1002
requested changes
Oct 1, 2020
backend/routers/psOne.js
Outdated
| @@ -29,9 +29,17 @@ router.get('/api/1', async (req, res) => { | |||
| queries.location = { $regex: new RegExp(req.query.location, 'i') }; | |||
| } | |||
|
|
|||
| if (req.query.industryDomain) { | |||
| queries.location = { $regex: new RegExp(req.query.industryDomain, 'i') }; | |||
backend/routers/psOne.js
Outdated
| } | ||
|
|
||
| if (req.query.branch) { | ||
| queries.location = { $regex: new RegExp(req.query.branch, 'i') }; |
There was a problem hiding this comment.
queries.location?
You cannot use regex with regex with an enum
amey-g
commented
Oct 2, 2020
pratham1002
reviewed
Oct 3, 2020
backend/routers/psOne.js
Outdated
| } | ||
|
|
||
| if (req.query.branch) { | ||
| queries.branches = { $in: [new RegExp(req.query.branch, 'i')] }; |
There was a problem hiding this comment.
I had recommended using the $in operator to get rid of the regex
if (req.query.branch) {
const branches = req.req.query.tags.split(' ');
queries.branches = { $in: branches };
}This will allow filtering multiple branches at once. when they are provided as a comma separated list.
There was a problem hiding this comment.
Okay. I'll replace the code with this. Sorry, I had not used regex before. Thanks for helping out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2 Please check the changes made. I have made the required changes to the station model as well as the search filters for them.