-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrunedRelaxedClockModel is broken after meanRate is changed to Function #15
Comments
Thanks for fixing! I start to think this should be reverted and made available for v2.7, since it breaks a few other clock models as well and causes an API change. |
I reverted the RealParameter => Function change, but plan to roll it back for v2.7. Perhaps this change can be reverted as well and parked for now. Sorry for the hassle. |
You do not need to revert the code for this fix. It works when |
Good point! |
@rbouckaert
PrunedRelaxedClockModel
has the code to assumeUCRelaxedClockModel
meanRate
isRealParameter
. I add the code to cast it intoRealParameter
aftermeanRate
is changed toFunction
.Please review my bug fix and close this issue if you are happy with the solution.
The text was updated successfully, but these errors were encountered: