-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Export Bonner Spreadsheet Features #1388
Open
WackyWeaver
wants to merge
20
commits into
development
Choose a base branch
from
1378-cohort-export
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+154
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added the events attended column, and now trying to clean up makeBonnerXls logic
…tem. Will implement new logic over comign days
… overhaul logic and get events by requirementmatch, not eventparticipant
…with event date. Need to implement for Bonner Events with frequency greater than one (All Bonner Meetings)
…ts for new logic need to be implemented
…ts for new logic need to be implemented
…wareDevTeam/celts into 1378-cohort-export
ojmakinde
force-pushed
the
1378-cohort-export
branch
from
January 30, 2025 21:38
8c197db
to
6d0de8d
Compare
…Team/celts into 1378-cohort-export
@@ -44,6 +56,28 @@ $(document).ready(function(){ | |||
} | |||
}); | |||
|
|||
$(".export-spreadsheet").on('click', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments might be useful here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
Fixes #1378
Changes
Created buttons associated with the new custom spreadsheets
Before
After
Also, created an Ajax function to associate each button to a specific flask route. We pass a start year and end year into the route using a values stored in the URL request. Then, if we want to additionally change the spreadsheet range, we can simply express a different range of values for the flask route function.
We also wrote into the bonner spreadsheet the status of each bonner requirement. If it was completed by the cohort member, we include the date of completion. If it is incomplete, we simply write "incomplete in the column of a given bonner member row.
Lastly, we wrote an mySQL script to migrate the Requirementmatch table data. Since much of the Event table data did not insert the bonner requirement events into the proper requirement table, we created a script to migrate all bonner events that include the select names of a given Bonner requirement.
Testing
git checkout 1378-cohort-export
flask run