Profile UI for CCE Minor Experiences. #1293

seedyjahateh · 2024-07-23T13:51:55Z

Issue Description

Fixes #1152

We needed to create a new page where we could create Summer Experiences with all of the information CELTS needs instead of just one text box.

Changes

Created a new tab system for navigating between Sustained Engagements, Summer Experience, and Other Engagements.
Created a new form for submitting a Summer Experience.
Created a new model for summerExperience.
Fixed up and made the Request Other Engagement page accessible.
Added phone number validation to the Company/Org part of the form.
Modularized the HTML for reusability.
Dynamically populated the years drop downs.
Wrote tests for the new createSummerExperience function.

Testing

After setting up environment and resetting the databases, run tests with ./tests/run_tests.sh
Run the application using flask run.
Click on the Minor Management tab in the Admin sidebar.
Click on any of the names under the CCE Minor Progress table (we did most of our testing on Ebenezer Ayisi.
Select the Summer Experience tab to open up the form.
Check the styling and then fill out all the information and submit.
Once kicked back to the Sustained Community Engagements page, return to Summer Experience and attempt to fill out the form but make sure to select Other for the 3rd to last question and no for the final question to verify the conditional check boxes are working.
Check the database with mysql -u root -proot -> use celts -> select * from summerexperience; to make sure the data you just submitted is all there.
Merge our PR :)

…ts into CCEminorTabs

…ts into CCEMinorTabs

…lts into CCEMinorTabs

… forms. Also implemented an 'Edt' and 'Withdraw' functionality for both forms.

BrianRamsay

No text in phone number field
Supervisor phone and email should not be required
Required fields should have the red * (we have that style from somewhere else)
Summer experience should connect through the IndividualRequirement table for the minor. See: Admin minor management page
No big duplicate chunks for read-only vs edit
Use jquery everywhere instead of vanilla javascript

app/__init__.py

app/controllers/minor/routes.py

app/models/summerExperience.py

app/templates/base.html

app/logic/minor.py

BrianRamsay · 2024-07-23T14:32:45Z

app/controllers/minor/routes.py

+
+
+@minor_bp.route('/cceMinor/<username>/updateSummerExperience', methods=['GET', 'POST'])
+def updateSummerExperience(username):


Update and create need to be combined or otherwise share functionality

app/templates/minor/profile.html

app/static/js/profile.js

bledsoef · 2024-08-22T18:51:07Z

Ask for additional information for Community-Engaged Summer Experience

Karina-Agliullova · 2024-11-20T16:55:36Z

Profile UI for CCE Minor Experiences (PR)

app/controllers/minor/routes.py

bledsoef · 2025-01-16T21:48:25Z

app/controllers/minor/routes.py

+
+
+
+@minor_bp.route('/profile/<username>/withdrawSummerExperience', methods=['POST'])


Lets move this code to a different PR since it can't be tested in this one.

bledsoef · 2025-01-16T21:50:50Z

app/controllers/minor/routes.py

+
+
+# ################################################## SUMMER EXPERIENCE END ###########################################################
+@minor_bp.route('/cceMinor/<username>/addOtherEngagement', methods=['POST'])


Lets move this to a different PR where we are implementing the addOtherEngagement functionality.

bledsoef · 2025-01-16T21:51:12Z

app/controllers/minor/routes.py

+        logging.error(f'An error occurred while adding the engagement: {e}', exc_info=True)
+        return redirect(url_for('minor.view_other_engagement', username=username))
+
+@minor_bp.route('/cceMinor/<username>/otherEngagement', methods=['GET'])


Lets move this to a different PR where we are implementing the addOtherEngagement functionality.

app/controllers/minor/routes.py

bledsoef · 2025-01-16T22:12:50Z

app/static/js/minorProfilePage.js

+      })
+      .catch(error => console.error('Error fetching terms:', error));
+
+  const editOtherButton = document.getElementById('edit-other-proposal-button');


Use ajax instead of JavaScript

bledsoef · 2025-01-16T22:12:55Z

app/static/js/minorProfilePage.js

+
+  editOtherButton.addEventListener('click', function() {
+      otherFormFields.forEach(field => field.removeAttribute('disabled'));
+      document.getElementById('edit-other-buttons').style.display = 'block';


Use ajax instead of JavaScript

bledsoef · 2025-01-16T22:12:59Z

app/static/js/minorProfilePage.js

+
+  cancelOtherButton.addEventListener('click', function() {
+      otherFormFields.forEach(field => field.setAttribute('disabled', 'disabled'));
+      document.getElementById('edit-other-buttons').style.display = 'none';


Use ajax instead of JavaScript

bledsoef · 2025-01-16T22:13:07Z

app/static/js/minorProfilePage.js

+      document.getElementById('view-other-buttons').style.display = 'block';
+  });
+
+  withdrawOtherButton.addEventListener('click', function() {


Use ajax instead of JavaScript

bledsoef · 2025-01-16T22:13:31Z

app/static/js/minorProfilePage.js

+  });
+
+  withdrawOtherButton.addEventListener('click', function() {
+      const experienceId = document.getElementById('other-experience-id').value;


Lets put this withdraw logic in a different PR with other withdrawal logic.

KafuiMark · 2025-01-16T22:43:44Z

app/static/js/minorProfilePage.js

+
+  cancelOtherButton.addEventListener('click', function() {
+      otherFormFields.forEach(field => field.setAttribute('disabled', 'disabled'));
+      document.getElementById('edit-other-buttons').style.display = 'none';


Use ajax instead.

Kafui123 · 2025-01-16T22:46:46Z

app/static/js/minorProfilePage.js

+    document.getElementById('edit-buttons').style.display = isEditMode ? 'block' : 'none';
+    document.getElementById('view-buttons').style.display = isEditMode ? 'none' : 'block';


Use ajax instead of javascript

…W PR

…y are supposed to

…NCE THIS COMMIT FOR FUTURE ISSUES

…r and changed the header to be of same size like in summerexperience

github-actions · 2025-01-30T00:06:36Z

View Code Coverage

esw0624 and others added 14 commits June 18, 2024 18:07

testing for UI CE Minor

34b93d5

Final Update

3067b1a

Fixed Final Update

0263d7e

Finalizing Final Update

21954ab

Merge branch 'development' of github.com:BCStudentSoftwareDevTeam/cel…

0eaf1c9

…ts into CCEminorTabs

Merge branch 'development' of github.com:BCStudentSoftwareDevTeam/cel…

85826e0

…ts into CCEMinorTabs

Update for Mahak

45ceed4

Merge branch 'development' of github.com:BCStudentSoftwareDevTeam/cel…

9f91bf1

…ts into CCEMinorTabs

Testing with Seedy

95ad2c9

Updates of the day

a311d35

Updating changes to GitHub

22857d3

Merge branch 'CCEMinorTabs' of github.com:BCStudentSoftwareDevTeam/ce…

9637377

…lts into CCEMinorTabs

Updating to GitHub 2

eeb1dc5

Completed the backend for both Summer Experience and Other Engagement…

3ada839

… forms. Also implemented an 'Edt' and 'Withdraw' functionality for both forms.

BrianRamsay requested changes Jul 23, 2024

View reviewed changes

ojmakinde self-assigned this Oct 25, 2024

ojmakinde removed their assignment Nov 8, 2024

Karina-Agliullova assigned Karina-Agliullova and Mbeweg Nov 8, 2024

Mbeweg added 2 commits November 8, 2024 16:18

Fixing comments

87323ca

Fixed the issues.

3e84f24

Mbeweg and others added 3 commits November 20, 2024 12:53

Fixed the issue.

652e258

Merge branch 'development' into CCEMinorTabs

ab2b6a3

Resolved PR Comments on January 15

2106b77

bledsoef requested changes Jan 16, 2025

View reviewed changes

KafuiMark reviewed Jan 16, 2025

View reviewed changes

Kafui123 reviewed Jan 16, 2025

View reviewed changes

Modifying the code based on comments

e518367

bledsoef and others added 29 commits January 22, 2025 16:29

combined the update and create routes

71c429a

resolved merge conflicts

cf4e13e

DELETED OTHER ENGAGEMENT LOGIC, CAN POTENTIALLY USE THIS FOR THE A NE…

59a0121

…W PR

Populated the select year dropdown with actual years

9e4684e

modularized the profile.html so each component has its own file

c2276d3

fixed merge conflicts

8e90b43

Committed changes

a54e069

Merged branch

354a39e

attached javascript to file and working on conditional text boxes

427c2f9

Populated the years dropdown menu

cb94bfe

Populated the dropdown years column

2fe03e9

Removed commented code

eaab491

modularized the two forms even more

c84049e

removed redundant student information

d449c8a

Merge branch 'development' into CCEMinorTabs

b44f3fe

deleted unused javascript

b8f88fa

modified some styling and made conditional text boxes appear when the…

52013a6

…y are supposed to

adjusted styling on both of the forms

1ad8991

set up two new fields and text boxes

97adb9a

deleted unused imports and log statement

0ee411c

started writing tests

5722384

Added 2+ years

22873b5

Merged

91bb011

Changed redirect

5031ea1

added a reload post form submit

7b0f03c

deleted update summer experience logic as we cant test it yet: REFERE…

f627402

…NCE THIS COMMIT FOR FUTURE ISSUES

added testing and renamed some fields in summerExperience

ae9f5a3

added phone number validation

b336262

Populated the drop down year menu, added experience information heade…

343ddee

…r and changed the header to be of same size like in summerexperience

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Profile UI for CCE Minor Experiences. #1293

Profile UI for CCE Minor Experiences. #1293

seedyjahateh commented Jul 23, 2024 •

edited by bledsoef

Loading

BrianRamsay left a comment

BrianRamsay Jul 23, 2024

bledsoef commented Aug 22, 2024

Karina-Agliullova commented Nov 20, 2024

bledsoef Jan 16, 2025

bledsoef Jan 16, 2025

bledsoef Jan 16, 2025

bledsoef Jan 16, 2025

bledsoef Jan 16, 2025

bledsoef Jan 16, 2025

bledsoef Jan 16, 2025

bledsoef Jan 16, 2025

KafuiMark Jan 16, 2025

Kafui123 Jan 16, 2025

github-actions bot commented Jan 30, 2025



		@minor_bp.route('/cceMinor/<username>/updateSummerExperience', methods=['GET', 'POST'])
		def updateSummerExperience(username):




		@minor_bp.route('/profile/<username>/withdrawSummerExperience', methods=['POST'])



		# ################################################## SUMMER EXPERIENCE END ###########################################################
		@minor_bp.route('/cceMinor/<username>/addOtherEngagement', methods=['POST'])

		document.getElementById('edit-buttons').style.display = isEditMode ? 'block' : 'none';
		document.getElementById('view-buttons').style.display = isEditMode ? 'none' : 'block';

Profile UI for CCE Minor Experiences. #1293

Are you sure you want to change the base?

Profile UI for CCE Minor Experiences. #1293

Conversation

seedyjahateh commented Jul 23, 2024 • edited by bledsoef Loading

Issue Description

Changes

Testing

BrianRamsay left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bledsoef commented Aug 22, 2024

Karina-Agliullova commented Nov 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 30, 2025

seedyjahateh commented Jul 23, 2024 •

edited by bledsoef

Loading