Enhanced 'import_users.py' script using logging module #1240
Conversation
… diagnosis using logging module
|
We have upgraded the |
|
This PR seemed to be pretty straightforward. I saw obvious problems with the logging, and I ran unit testing for this. This was not client side, so I saw no need to try to break it on that end. I would approve this PR. |
|
Can you resolve the merge conflicts that exist? @ali-ramazani |
…ts into import-user-logging-crontab
|
I was running this in a devcontainer and I couldn't check this script with tracy but I looked over it and everything looks to be good. Let's give this one final run before we merge it. |
There was a problem hiding this comment.
Based on https://docs.python.org/3/library/logging.html#levels, the log levels should be better defined. Log level DEBUG should show all of the output, INFO should give a summary of what the script did (count of users updated/inserted, etc), and WARNING should be when something unexpected happens, or we can't match a user.
We should be able to control the log levels in an argument to the script.
The output should go to stdout, not to a file. Let crontab control where the output goes.
…udentSoftwareDevTeam/celts into import-user-logging-crontab
| build-essential libssl-dev libffi-dev freetds-dev freetds-bin unixodbc-dev tdsodbc | ||
|
|
||
| RUN sudo bash -c "echo -e '[FreeTDS]\nDescription=FreeTDS Driver\nDriver=/usr/lib/x86_64-linux-gnu/odbc/libtdsodbc.so\ | ||
| \nSetup=/usr/lib/x86_64-linux-gnu/odbc/libtdsS.so' >> /etc/odbcinst.ini" |
There was a problem hiding this comment.
I couldn't find a way to break this into two lines while keeping the indentation style so we're just going to have to live with it.
Fixes issue #1053
We enhanced the
import_users.pyscript by integrating Python's logging module to provide detailed and descriptive log messages. These improvements will make thecron.logfile significantly more informative, aiding in monitoring the script's execution and diagnosing any issues that arise from crontab scheduled tasks.