4 test other database #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZedTT
reviewed
Dec 11, 2020
Comment on lines
+85
to
+87
| // string connStr = $"Data Source={host},{port};Integrated Security=False;"; | ||
| // connStr += $"User ID={username};Password={password};Database={db};"; | ||
| // connStr += $"Connect Timeout=30;Encrypt=False;TrustServerCertificate=True;ApplicationIntent=ReadWrite;MultiSubnetFailover=False"; |
There was a problem hiding this comment.
is there a good reason for us to have this commented out code in master, or can we remove it?
Should at least add a comment explaining what it is and why it is commented out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both MySQL and SQLite database types working with project.
MSSql attempted to run with project, but had bugs attempted to be troubleshooted. Namely, the database update does not work due to problems with tables with multiple foreign keys. Will need to be looked at further.