DataSourceModelAccess.retrieve and related updates #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update DataSourceModelAccess.retrieve to work properly with the translate layer.
Closes #168
Highlights:
id
property to QueryBaseRationale for removing QueryById:
A particular ModelAccess class (e.g., MonitoringFeatureModelAccess) should use the related query class (e.g. QueryMonitoringFeature). In particular, querying by Monitoring Feature id benefits from having the feature_type available as well.
Type of change
How Has This Been Tested?
Test Configuration
PR Self Evaluation