[BRMO-379] [BRMO-332] [BRMO-381] Aanpassingen aan BRK datamodel en BAG/BRK combinatieviews #2282
+87
−538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprins
requested changes
Nov 1, 2024
There was a problem hiding this comment.
helaas zitten er syntax en logische fouten in waardoor de build en CI procedures falen, zie de status van de jobs, onder andere:
- https://github.com/B3Partners/brmo/actions/runs/11458219583/job/31880143111?pr=2282#step:11:508 (de lijst met views in dient te worden aangepast
- https://github.com/B3Partners/brmo/actions/runs/11458219571/job/31880142286?pr=2282#step:9:252
- https://github.com/B3Partners/brmo/actions/runs/11458219568/job/31880142436?pr=2282#step:8:61728
- ...
En mogelijk nog meer; graag zorgen dat de check op het pull request allemaal groene vinkjes heeft, daarna opnieuw voor review aanbieden
mprins
reviewed
Nov 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2282 +/- ##
========================================
+ Coverage 38% 38% +1%
Complexity 806 806
========================================
Files 371 371
Lines 18863 18863
Branches 1777 1777
========================================
+ Hits 7153 7155 +2
+ Misses 11138 11136 -2
Partials 572 572 |
mprins
reviewed
Nov 12, 2024
mprins
changed the title
mprins
approved these changes
Nov 14, 2024
Ten behoeve van performance van (materialized) views zijn onderstaande indexes aangemaakt
FK Constraints in Recht tabel verwijderd nav https://b3partners.atlassian.net/browse/BRMO-332
Verwijderde views koppelden BRK 1.0 aan BAG 2.0. BRK 1.0 is outdated en wordt niet meer geleverd
Verwijderde views koppelden BRK1.0 aan BAG 2.0. BRK 1.0 wordt niet meer ondersteund
…taanuit en recht.isbetrokkenbij
mprins
force-pushed
the
BRMO-379-&-332-&-381
branch
from
497af1c
to
b695e9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aanpassingen aan BRK datamodel en BAG/BRK combinatieviews.
Resolves: