Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove osm-arc validations #281

Open
wants to merge 1 commit into
base: k8s-extension/public
Choose a base branch
from

Conversation

nshankar13
Copy link


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az k8s-extension create --cluster-name --resource-group --cluster-type connectedClusters --extension-type Microsoft.openservicemesh --scope cluster -release-train stable --name osm --release-namespace arc-osm-system --version 1.2.9 --auto-upgrade-minor-version false

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Signed-off-by: nshankar <[email protected]>
@NarayanThiru
Copy link
Collaborator

what is the reason for removing this validation? Is it not applicable anymore? Can you pl. update the PR description with details?

@NarayanThiru
Copy link
Collaborator

@nshankar13, what is the reason for removing this validation? Is it not applicable anymore? Can you pl. update the PR description with details?

@@ -52,8 +52,8 @@ def Create(self, cmd, client, resource_group_name, cluster_name, name, cluster_t
# NOTE-2: Return a valid Extension object, Instance name and flag for Identity
create_identity = True

if cluster_type == "connectedClusters":
_validate_tested_distro(cmd, resource_group_name, cluster_name, version, release_train)
# if cluster_type == "connectedClusters":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't need this validation anymore, remove the code altogether, not leave it commented out. If you need it later, you will still be able to recover from this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants