Skip to content

Commit

Permalink
add 472 to as target fwk and update publisher info (#91)
Browse files Browse the repository at this point in the history
* add 472 to as target fwk and update publisher info

* Update Directory.Build.props

* add reference to test dict.build.props

* revert back and only take George's update

* fix test

---------

Co-authored-by: George Krechar <[email protected]>
  • Loading branch information
jennyf19 and GeoK authored Jul 11, 2023
1 parent aa0254c commit 24d81a0
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net462'">
<PackageReference Include="System.Net.Http" Version="4.3.4" />
<Reference Include="System.Net.Http" />
</ItemGroup>

<ItemGroup Label="Build Tools" Condition="$([MSBuild]::IsOsPlatform('Windows'))">
Expand Down
4 changes: 2 additions & 2 deletions build/template-sign-binary.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ steps:
"parameters": [
{
"parameterName": "OpusName",
"parameterValue": "Microsoft.Identity.Abstractions"
"parameterValue": "Microsoft"
},
{
"parameterName": "OpusInfo",
"parameterValue": "http://test"
"parameterValue": "http://www.microsoft.com"
},
{
"parameterName": "PageHash",
Expand Down
4 changes: 4 additions & 0 deletions test/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,8 @@
<CoverletCollectorVersion>3.1.2</CoverletCollectorVersion>
</PropertyGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net462'">
<Reference Include="System.Net.Http" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net7.0;net462;net472</TargetFrameworks>
<TargetFrameworks>net7.0;net462</TargetFrameworks>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<LangVersion>9.0</LangVersion>
Expand Down

0 comments on commit 24d81a0

Please sign in to comment.