Lab consistency changes, Fixes AB#3043333 #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadidurah
added
the
No-Changelog
|
✅ Work item link check complete. Description contains link AB#3043333 to an Azure Boards work item. |
github-actions
bot
changed the title
shahzaibj
reviewed
Oct 9, 2024
.../main/com/microsoft/identity/labapi/utilities/authentication/LabApiAuthenticationClient.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Oct 9, 2024
.../main/com/microsoft/identity/labapi/utilities/authentication/LabApiAuthenticationClient.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Oct 9, 2024
labapi/src/main/java/com/microsoft/identity/internal/test/labapi/ApiClient.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Oct 9, 2024
labapi/src/main/java/com/microsoft/identity/internal/test/labapi/ApiClient.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Oct 9, 2024
labapi/src/main/java/com/microsoft/identity/internal/test/labapi/ApiClient.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Oct 9, 2024
labapi/src/main/java/com/microsoft/identity/internal/test/labapi/ApiClient.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Oct 9, 2024
labapi/src/main/java/com/microsoft/identity/internal/test/labapi/ApiClient.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Oct 9, 2024
.../main/com/microsoft/identity/labapi/utilities/authentication/LabApiAuthenticationClient.java
Show resolved
Hide resolved
…tion-library-common-for-android into fadi/lab-cons ge to explain why this merge is necessary,
…es/authentication/LabApiAuthenticationClient.java Co-authored-by: Shahzaib <[email protected]>
…pi/ApiClient.java Co-authored-by: Shahzaib <[email protected]>
…pi/ApiClient.java Co-authored-by: Shahzaib <[email protected]>
…pi/ApiClient.java Co-authored-by: Shahzaib <[email protected]>
…pi/ApiClient.java Co-authored-by: Shahzaib <[email protected]>
melissaahn
approved these changes
Oct 11, 2024
fadidurah
added
the
Skip-Consumers-Check
shahzaibj
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to fix some ui tests involving 1st party apps, and changes to improve lab api reliability
changes:
Add a retry in ApiClientRemoved this, retrying at this level will through exception, okhttp calls cannot be executed twice (https://square.github.io/okhttp/2.x/okhttp/index.html?com/squareup/okhttp/Call.html). Instead, I added a retry in LabClient for user fetch.AB#3043333