Check inbox code validity in Native Auth E2E tests, Fixes AB#3037823 #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
rmccahill
added
the
No-Changelog
|
✅ Work item link check complete. Description contains link AB#3037823 to an Azure Boards work item. |
rmccahill
changed the title
github-actions
bot
changed the title
rmccahill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic for retrieving a code from the test inbox - the code retrieved will be checked in the calling test to ensure that the retrieved code is valid, since we occasionally get expired codes from the inbox. If a code is invalid, the test is retried, filtering out the emails previously retrieved to ensure we're getting the latest email. If we don't get a valid code after 3 tries, an IllegalStateException will be thrown. The E2E tests will use this new function in this PR: https://github.com/AzureAD/microsoft-authentication-library-for-android/compare/robert/retry-submit-code-e2e-tests
Work Item: AB#3037823