Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide empty image when no video is present on QR +PIN auth, Fixes AB#3019283 #2424

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

p3dr0rv
Copy link
Contributor

@p3dr0rv p3dr0rv commented Jun 6, 2024

When QR + PIN auth is enabled, for a glimpse of a second you can see the default image.
image

The preferred experience is not to show the default image at all, so we are providing an empty image instead

AB#3019283

@p3dr0rv p3dr0rv marked this pull request as ready for review June 6, 2024 00:30
@p3dr0rv p3dr0rv requested a review from a team as a code owner June 6, 2024 00:30
@p3dr0rv p3dr0rv marked this pull request as draft August 27, 2024 23:38
Copy link

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@p3dr0rv p3dr0rv marked this pull request as ready for review October 15, 2024 18:59
Copy link

✅ Work item link check complete. Description contains link AB#3019283 to an Azure Boards work item.

@github-actions github-actions bot changed the title Provide empty image when no video is present on QR +PIN auth Provide empty image when no video is present on QR +PIN auth, Fixes AB#3019283 Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants