Small fixes #2304
Merged
Small fixes #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpdome
force-pushed
the
rapong/smallfix
branch
from
c8798d9
to
abe1390
Compare
rpdome
force-pushed
the
rapong/smallfix
branch
from
abe1390
to
2e72dfc
Compare
rpdome
added
the
No-Changelog
somalaya
approved these changes
Jan 30, 2024
fadidurah
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OneAuthSharedFunctions, andpackage com.microsoft.identity.common.sharedwithoneauthWe'll start keeping interfaces that are also consumed by OneAuth here.With a clear interface, the amount of "android msal team making an internal change and break oneauth" should gradually reduce in the long run.
(yes... I broke them again....)
(ps. I'm not moving all the shared code in this PR. That would introduce a major breaking change 🤣 )
AccountManagerBackupIpcStrategyTargetingSpecificBrokerApp