Redirect to hub app in case of NAA flow #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohitc1
reviewed
Jan 19, 2024
...ain/java/com/microsoft/identity/common/internal/ui/browser/BrowserAuthorizationStrategy.java
Show resolved
Hide resolved
Yes, I am working on adding the UT in broker PR. It would not be part of this PR |
p3dr0rv
approved these changes
Jan 25, 2024
somalaya
force-pushed
the
somalaya/fix-naa-blankscreen-issue
branch
from
3ec19f8
to
85f094f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : Found a bug while ACW team was testing NAA flow. In case of an interrupt flow, the redirectURI of calling apps would be passed to eSTS as the redirectURI. In NAA flow, redirectURI parameter is child app's redirectURI (which could just be a single page app's redirectURI). eSTS always returns the auth code back to hub app's redirectURI. We would not be able to read/extract the auth code received because the redirectURI eSTS sends code to and the redirectURI we have passed to WebviewAuthorizationStrategy are different.
Fix : Whenever it is a nested app flow (brkRedirectURI!=null), I am passing hub app's redirectURI to authorization strategy to pass the comparison that is made at this line
microsoft-authentication-library-common-for-android/common/src/main/java/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java
Line 182 in 4900edb