Implement updates of the Native Auth API (#2261)

Summary of changes: - Update error parsing based on the updated error codes and sub error property returned by the API - Convert all "flow" tokens to continuation token - Use continuation token for sign in after sign up instead of SLT
AzureAD · Jan 12, 2024 · 209ee7f · 209ee7f
1 parent 9eeddcb
commit 209ee7f
Show file tree

Hide file tree

Showing 71 changed files with 1,089 additions and 1,503 deletions.
diff --git a/changelog.txt b/changelog.txt
@@ -1,5 +1,6 @@
 V.Next
 ---------
+- [MINOR] Implement updates of the native auth web API (#2261)
 
 V.17.0.0
 ---------

diff --git a/...internal/commands/SignInWithSLTCommand.kt → ...nds/SignInWithContinuationTokenCommand.kt b/...internal/commands/SignInWithSLTCommand.kt → ...nds/SignInWithContinuationTokenCommand.kt
@@ -23,37 +23,37 @@
 package com.microsoft.identity.common.nativeauth.internal.commands
 
 import com.microsoft.identity.common.nativeauth.internal.controllers.NativeAuthMsalController
-import com.microsoft.identity.common.java.nativeauth.commands.parameters.SignInWithSLTCommandParameters
-import com.microsoft.identity.common.java.nativeauth.controllers.results.SignInWithSLTCommandResult
+import com.microsoft.identity.common.java.nativeauth.commands.parameters.SignInWithContinuationTokenCommandParameters
+import com.microsoft.identity.common.java.nativeauth.controllers.results.SignInWithContinuationTokenCommandResult
 import com.microsoft.identity.common.java.logging.LogSession
 import com.microsoft.identity.common.java.logging.Logger
 
 /**
- * Command class to call controllers to use short live token generated from sign in/self-service-password-reset flow to get the user authenticated.
+ * Command class to call controllers to use continuation token generated from sign in/self-service-password-reset flow to get the user authenticated.
  * {@see com.microsoft.identity.common.java.controllers.CommandDispatcher}.
  */
-class SignInWithSLTCommand(
-    private val parameters: SignInWithSLTCommandParameters,
+class SignInWithContinuationTokenCommand(
+    private val parameters: SignInWithContinuationTokenCommandParameters,
     private val controller: NativeAuthMsalController,
     publicApiId: String
-) : BaseNativeAuthCommand<SignInWithSLTCommandResult>(
+) : BaseNativeAuthCommand<SignInWithContinuationTokenCommandResult>(
     parameters,
     controller,
     publicApiId
 ) {
 
     companion object {
-        private val TAG = SignInWithSLTCommand::class.java.simpleName
+        private val TAG = SignInWithContinuationTokenCommand::class.java.simpleName
     }
 
     /**
      * The execution part of the command, to be run on the background thread.
-     * It calls the signInWithSLT method of the native auth MSAL controller with the given parameters.
+     * It calls the signInWithContinuationToken method of the native auth MSAL controller with the given parameters.
      */
-    override fun execute(): SignInWithSLTCommandResult {
+    override fun execute(): SignInWithContinuationTokenCommandResult {
         LogSession.logMethodCall(TAG, "${TAG}.execute")
 
-        val result = controller.signInWithSLT(
+        val result = controller.signInWithContinuationToken(
             parameters = parameters
         )
 

diff --git a/...com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthMsalController.kt b/...com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthMsalController.kt
diff --git a/common/src/main/java/com/microsoft/identity/common/nativeauth/internal/util/CommandUtil.java b/common/src/main/java/com/microsoft/identity/common/nativeauth/internal/util/CommandUtil.java
@@ -27,7 +27,7 @@
 import com.microsoft.identity.common.java.nativeauth.commands.parameters.SignInStartUsingPasswordCommandParameters;
 import com.microsoft.identity.common.java.nativeauth.commands.parameters.SignInSubmitCodeCommandParameters;
 import com.microsoft.identity.common.java.nativeauth.commands.parameters.SignInSubmitPasswordCommandParameters;
-import com.microsoft.identity.common.java.nativeauth.commands.parameters.SignInWithSLTCommandParameters;
+import com.microsoft.identity.common.java.nativeauth.commands.parameters.SignInWithContinuationTokenCommandParameters;
 import com.microsoft.identity.common.java.request.SdkType;
 
 import java.util.List;
@@ -55,14 +55,14 @@ public static SignInStartUsingPasswordCommandParameters createSignInStartCommand
     }
 
     /**
-     * Adds scopes to [SignInWithSLTCommandParameters] object and returns a new
-     * [SignInWithSLTCommandParameters] object.
+     * Adds scopes to [SignInWithContinuationTokenCommandParameters] object and returns a new
+     * [SignInWithContinuationTokenCommandParameters] object.
      * @param parameters input command parameter
      * @param defaultScopes scopes to be added
-     * @return [SignInWithSLTCommandParameters] object with scopes
+     * @return [SignInWithContinuationTokenCommandParameters] object with scopes
      */
-    public static SignInWithSLTCommandParameters createSignInWithSLTCommandParametersWithScopes(
-            SignInWithSLTCommandParameters parameters,
+    public static SignInWithContinuationTokenCommandParameters createSignInWithContinuationTokenCommandParametersWithScopes(
+            SignInWithContinuationTokenCommandParameters parameters,
             List<String> defaultScopes
     ) {
         return parameters.toBuilder()
@@ -103,15 +103,15 @@ public static SignInSubmitPasswordCommandParameters createSignInSubmitPasswordCo
     }
 
     /**
-     * Adds credential token to [SignInStartUsingPasswordCommandParameters] object and returns a new
+     * Adds continuation token to [SignInStartUsingPasswordCommandParameters] object and returns a new
      * [SignInSubmitPasswordCommandParameters] object.
      * @param parameters input command parameter
-     * @param credentialToken credential token to be added
-     * @return [SignInStartUsingPasswordCommandParameters] object with credential token
+     * @param continuationToken continuation token to be added
+     * @return [SignInStartUsingPasswordCommandParameters] object with continuation token
      */
     public static SignInSubmitPasswordCommandParameters createSignInSubmitPasswordCommandParameters(
             SignInStartUsingPasswordCommandParameters parameters,
-            String credentialToken
+            String continuationToken
     ) {
         final SignInSubmitPasswordCommandParameters commandParameters =
                 SignInSubmitPasswordCommandParameters.builder()
@@ -127,7 +127,7 @@ public static SignInSubmitPasswordCommandParameters createSignInSubmitPasswordCo
                         .sdkVersion(parameters.getSdkVersion())
                         .powerOptCheckEnabled(parameters.isPowerOptCheckEnabled())
                         .authority(parameters.getAuthority())
-                        .credentialToken(credentialToken)
+                        .continuationToken(continuationToken)
                         .password(parameters.getPassword())
                         .scopes(parameters.getScopes())
                         .challengeType(parameters.getChallengeType())