Make updates to syncAfter and lastRefreshRequest atomic #3090
+74
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make updates to syncAfter and lastRefreshRequest atomic
Description
syncAfter can be updated on a background thread,
lastRefreshRequest could be simultaneously updated
by different threads as there is not a lock around
the check and update.
To be able to do an atomic write, DateTimeOffset fields had
to be switched to DateTime fields. DateTime is a struct
with a single ulong field, DateTimeOffset has two fields,
one for the datetime, one for the offset. DateTime can
be treated as a long for this reason (and is in DateTime's ToBinary method).
This also means ConfigurationManager can continue to use DateTime instead of an
int, which is much more ergonomic.
See the [implementation] for when you can't use a long and need to use a ulong: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System/DateTime.cs#L1316
Fixes #2900