Feature/time provider #2612
Open
Feature/time provider #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trejjam
force-pushed
the
feature/time-provider
branch
from
74af63a
to
b3a1675
Compare
|
Hi. Can you take a look at this? I would love to have some feedback :) |
|
@pmaytak This PR is a follow-up of the previous one you reviewed. We would appreciate your review here too. |
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition=" ($([MSBuild]::GetTargetFrameworkIdentifier('$(TargetFramework)')) == '.NETCoreApp' And $([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), '8.0'))) "> | ||
| <DefineConstants>$(DefineConstants);SUPPORTS_TIME_PROVIDER</DefineConstants> |
There was a problem hiding this comment.
Why a new define and not just NET8+
There was a problem hiding this comment.
It is not a big reason but a matter of personal preference. It allows easy integration of Microsoft.Bcl.TimeProvider if requested.
If you prefer NET8_0_OR_GREATER, I will change it.
trejjam
force-pushed
the
feature/time-provider
branch
from
b3a1675
to
8fb3274
Compare
|
There is also available timezone info, GetElapsedTime, a Timer, ... I prefer to use these in a following PR. |
trejjam
force-pushed
the
feature/time-provider
branch
from
8fb3274
to
377bb9b
Compare
|
@iNinja and @FuPingFranco (@brentschmaltz ) are you considering this with the changes you are doing to validationParameters? |
trejjam
force-pushed
the
feature/time-provider
branch
from
377bb9b
to
b8e5780
Compare
alexmurari
reviewed
Aug 27, 2024
� Conflicts: � build/common.props
trejjam
force-pushed
the
feature/time-provider
branch
from
b8e5780
to
385311e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use TimeProvider instead of DateTime.Now
This PR adds
TimeProviderfor .net8+ targets. It's done as an additional property,TimeProvider, on Descriptor/Parameter classes.Description
I added
TimeProviderto nearly all usages of DateTime.Now. Some were too difficult to add (BC Break).Fixes #2572