This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
[WIP] Add Azure region to support regional ESTS-r #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faix
commented
Jun 6, 2023
This comment was marked as resolved.
This comment was marked as resolved.
bgavrilMS
reviewed
Jun 7, 2023
bgavrilMS
reviewed
Jun 7, 2023
src/New-MsalClientApplication.ps1
Outdated
| [Parameter(Mandatory = $false, ParameterSetName = 'ConfidentialClientClaims', ValueFromPipelineByPropertyName = $true)] | ||
| [Parameter(Mandatory = $false, ParameterSetName = 'ConfidentialClientAssertion', ValueFromPipelineByPropertyName = $true)] | ||
| [Parameter(Mandatory = $false, ParameterSetName = 'ConfidentialClient-InputObject', ValueFromPipelineByPropertyName = $true)] | ||
| [string] $AzureRegion = [Microsoft.Identity.Client.ConfidentialClientApplication]::AttemptRegionDiscovery |
There was a problem hiding this comment.
Shouldn't this be a parameter of type string? ESTS-R SHOULD most certainly not be enabled by default.
Note that for ESTS-R to work you need Certificate with SN/I, via the "sendX5C" param. Is this exposed?
There was a problem hiding this comment.
The parameter was of type string. Here i was simply setting it to the TryAutoDetect const that the library provides. The SendX5C parameter is exposed yes
bgavrilMS
reviewed
Jun 7, 2023
bgavrilMS
suggested changes
Jun 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confidential clients should use regional ests-r