-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable configurable namespaces, expose more options in helm chart, add stable tag, fix v2 API routing #36
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 69.53% 70.70% +1.17%
==========================================
Files 36 36
Lines 1812 1823 +11
==========================================
+ Hits 1260 1289 +29
+ Misses 552 534 -18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good. Left a comment around auto-detecting the namespace the application is deployed in.
This also addresses the route registration issue exposed in #34 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I assume you'll have a colleague review this 🙂
…rt, add stable tag, fix v2 API routing (#36) * ci: tag stable release * chore: refactor helm chart * feat: add option for tolerations * feat: make namespace configurable * fix: correct syntax issues * fix: address route registration issue * feat: auto-detect pod namespace * refactor: update var name * fix: address if check * tests: add root handler tests * ci: reduce diff coverage target
…rt, add stable tag, fix v2 API routing (#36) * ci: tag stable release * chore: refactor helm chart * feat: add option for tolerations * feat: make namespace configurable * fix: correct syntax issues * fix: address route registration issue * feat: auto-detect pod namespace * refactor: update var name * fix: address if check * tests: add root handler tests * ci: reduce diff coverage target Signed-off-by: Aviral Takkar <[email protected]>
Fixes #35