Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable configurable namespaces, expose more options in helm chart, add stable tag, fix v2 API routing #36

Merged
merged 11 commits into from
Apr 10, 2024

Conversation

avtakkar
Copy link
Contributor

@avtakkar avtakkar commented Apr 8, 2024

Fixes #35

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 70.70%. Comparing base (b71ac9f) to head (fd7e2a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   69.53%   70.70%   +1.17%     
==========================================
  Files          36       36              
  Lines        1812     1823      +11     
==========================================
+ Hits         1260     1289      +29     
+ Misses        552      534      -18     
Files Coverage Δ
internal/context/context.go 100.00% <ø> (ø)
internal/handlers/root.go 48.88% <100.00%> (+48.88%) ⬆️
internal/k8s/events/events.go 94.00% <100.00%> (ø)
internal/handlers/v2/handler.go 37.77% <0.00%> (ø)
cmd/proxy/main.go 0.00% <0.00%> (ø)
pkg/k8s/k8s.go 56.00% <70.00%> (+9.33%) ⬆️
internal/routing/router.go 33.33% <10.00%> (-0.27%) ⬇️

Copy link

@rbjorklin rbjorklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. Left a comment around auto-detecting the namespace the application is deployed in.

cmd/proxy/cmd.go Outdated Show resolved Hide resolved
@avtakkar
Copy link
Contributor Author

avtakkar commented Apr 9, 2024

This also addresses the route registration issue exposed in #34 .

Copy link

@rbjorklin rbjorklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I assume you'll have a colleague review this 🙂

@avtakkar avtakkar changed the title feat: enable configurable namespaces, expose more options in helm chart, add stable tag feat: enable configurable namespaces, expose more options in helm chart, add stable tag, fix v2 API routing Apr 10, 2024
@avtakkar avtakkar merged commit d69157d into main Apr 10, 2024
8 checks passed
@avtakkar avtakkar deleted the ci/tag branch April 10, 2024 00:38
avtakkar added a commit that referenced this pull request Jul 24, 2024
…rt, add stable tag, fix v2 API routing (#36)

* ci: tag stable release

* chore: refactor helm chart

* feat: add option for tolerations

* feat: make namespace configurable

* fix: correct syntax issues

* fix: address route registration issue

* feat: auto-detect pod namespace

* refactor: update var name

* fix: address if check

* tests: add root handler tests

* ci: reduce diff coverage target
avtakkar added a commit that referenced this pull request Jul 24, 2024
…rt, add stable tag, fix v2 API routing (#36)

* ci: tag stable release

* chore: refactor helm chart

* feat: add option for tolerations

* feat: make namespace configurable

* fix: correct syntax issues

* fix: address route registration issue

* feat: auto-detect pod namespace

* refactor: update var name

* fix: address if check

* tests: add root handler tests

* ci: reduce diff coverage target

Signed-off-by: Aviral Takkar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor snags during deployment
3 participants