Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.5.x] fix: exclude SKUs without compatible VM image and fix GPU bootstrap #628

Merged
merged 3 commits into from
Dec 18, 2024
Merged

[release-0.5.x] fix: exclude SKUs without compatible VM image and fix GPU bootstrap #628

merged 3 commits into from
Dec 18, 2024

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Dec 18, 2024 •
edited
Loading

Description

This cherry picks into release-v0.5.x branch:

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

Exclude from consideration VM SKUs that don't have a compatible (= tagged for NVMe) VM image
Fix GPU bootstrap and update the list of supported GPU VM SKUs

@tallaxes tallaxes added area/vm-images Issues or PRs related to VM images or image galleries area/provisioning Issues or PRs related to provisioning (instance provider) labels Dec 18, 2024
@tallaxes tallaxes self-assigned this Dec 18, 2024
@tallaxes tallaxes changed the title [release-0.5.x] fix: temp exclude SKUs without compatible VM image [release-0.5.x] fix: exclude SKUs without compatible VM image and fix GPU bootstrap Dec 18, 2024
Bryce-Soghigian
Bryce-Soghigian approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving backport

@tallaxes tallaxes merged commit 426f2dc into release-v0.5.x Dec 18, 2024
21 of 22 checks passed
@tallaxes tallaxes deleted the tallaxes/fix-cig-nvme-0.5.x branch December 18, 2024 23:07
@tallaxes tallaxes mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bryce-Soghigian Bryce-Soghigian Bryce-Soghigian approved these changes

Assignees

@tallaxes tallaxes

Labels
area/provisioning Issues or PRs related to provisioning (instance provider) area/vm-images Issues or PRs related to VM images or image galleries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tallaxes @Bryce-Soghigian @comtalyst