feat: v1 migration and adaptation #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and migration to kube-system)
(typecheck detecting multiple main.go)
Bryce-Soghigian
previously approved these changes
Oct 24, 2024
charliedmcb
reviewed
Oct 24, 2024
charliedmcb
reviewed
Oct 24, 2024
charliedmcb
reviewed
Oct 24, 2024
charliedmcb
reviewed
Oct 24, 2024
charliedmcb
reviewed
Oct 24, 2024
charliedmcb
reviewed
Oct 24, 2024
comtalyst
approved these changes
Oct 24, 2024
charliedmcb
reviewed
Oct 24, 2024
charliedmcb
reviewed
Oct 24, 2024
charliedmcb
reviewed
Oct 24, 2024
charliedmcb
reviewed
Oct 24, 2024
charliedmcb
reviewed
Oct 25, 2024
charliedmcb
reviewed
Oct 25, 2024
| Data: map[string][]byte{ | ||
| certresources.ServerKey: []byte("present"), | ||
| certresources.ServerCert: []byte("present"), | ||
| // certresources.CACert: []byte("missing"), |
There was a problem hiding this comment.
commented, can be removed?
charliedmcb
reviewed
Oct 25, 2024
| ) | ||
|
|
||
| //go:generate controller-gen crd object:headerFile="../../hack/boilerplate.go.txt" paths="./..." output:crd:artifacts:config=crds | ||
| var ( | ||
| Group = "karpenter.azure.com" | ||
| //CompatibilityGroup = "compatibility." + Group |
There was a problem hiding this comment.
commented out, can be removed?
charliedmcb
reviewed
Oct 25, 2024
| This field may not be empty. | ||
| maxLength: 1024 | ||
| minLength: 1 | ||
| pattern: ^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$ |
There was a problem hiding this comment.
If it should be camelCase, should we enforce the first letter is lowercase?
charliedmcb
reviewed
Oct 25, 2024
| enum: | ||
| - "True" | ||
| - "False" | ||
| - Unknown |
There was a problem hiding this comment.
Should Unknown also be quoted?
charliedmcb
reviewed
Oct 25, 2024
| This field may not be empty. | ||
| maxLength: 1024 | ||
| minLength: 1 | ||
| pattern: ^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$ |
There was a problem hiding this comment.
Should we enforce starting with a lowercase letter if it should be camel case?
charliedmcb
reviewed
Oct 25, 2024
| enum: | ||
| - "True" | ||
| - "False" | ||
| - Unknown |
There was a problem hiding this comment.
Should Unknown be quoted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to Karpenter v1 API, with many follow-ups. Summary of changes (mostly grouped by commits):
kube-systemby default, update Helm charts (many changes), update karpenter-values-template (remove drift feature gate); enable webhooks (including webhook injection into CRDs); includes enablement of webhooks in CCP context (thank you, @matthchr!)How was this change tested?
make presubmitDoes this change impact docs?
Release Note
Next
AKSNodeClass
Testing
Other