feat: CSE-based bootstrapping with bootstrapping client mode #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and migration to kube-system)
(typecheck detecting multiple main.go)
comtalyst
force-pushed
the
comtalyst/nap-cse-bootstrapping
branch
from
9c691b3 to
ff4706a
Compare
comtalyst
commented
Oct 19, 2024
…align with AgentBaker
This requires quite a bit of hacking, mostly overriding certain things in the ctx. The major items are: * Copy and modify knative/pkg/webhook/resourcesemantics/conversion to support CRD clientConfig.url in addition to clientConfig.service. * Copy and modify karpenter/pkg/webhooks/webhooks.go to support overriding the informer factory, so that we can point it at the CCP APIServer rather than overlay. * Override Start and supporting methods on the provider specific operator in pkg/operator/operator.go to allow invoking our modified version of karpenter/pkg/webhooks/webhooks.go.
…alyst/nap-cse-bootstrapping
…alyst/nap-cse-bootstrapping
tallaxes
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Using provision servers provide opportunities for us to delegate deterministic bootstrapping details away to keep our maintenance focus on autoscaling.
For the first mode introduced here—the bootstrapping client—will also switch back to CSE-based bootstrapping for general stability. The server is expected to provide custom data and CSE based on our inputs of
ProvisionProfile. See swagger file for specifics.This pathway will be supported by NAP only, for now.
How was this change tested?
Does this change impact docs?
Release Note