Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect NodePool zone requirement (if any) #47

Merged
merged 3 commits into from
Nov 28, 2023
Merged

fix: respect NodePool zone requirement (if any) #47

merged 3 commits into from
Nov 28, 2023

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Nov 28, 2023 •
edited
Loading

Description

Respect topology.kubernetes.io/zone NodePool requirement, if specified

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

@tallaxes
Copy link
Collaborator Author

/test

@tallaxes tallaxes marked this pull request as ready for review November 28, 2023 08:21
tallaxes
tallaxes commented Nov 28, 2023
View reviewed changes
Copy link
Collaborator Author

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@tallaxes tallaxes merged commit 01acc1c into main Nov 28, 2023
8 checks passed
@tallaxes tallaxes deleted the tallaxes/zoneselector branch November 28, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bryce-Soghigian Bryce-Soghigian Bryce-Soghigian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tallaxes @Bryce-Soghigian