feat: supporting additional handing for TotalRegionalCores quota error, and adding better customer facing error messages on nodeclaim #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juan-lee Let me know if you think this leads to a better experience in more clearly communicating you hit TotalRegionCores errors! |
Bryce-Soghigian
force-pushed
the
bsoghigian/total-regional-cores
branch
from
535a1b7 to
99d8a74
Compare
…r, alongside adding better customer facing error messages for the controller errors that end up in the nodeclaim
Co-authored-by: Alex Leites <[email protected]>
style: removing lint exception rule
Bryce-Soghigian
force-pushed
the
bsoghigian/total-regional-cores
branch
from
f734a32 to
089d0a7
Compare
tallaxes
requested changes
Dec 1, 2023
Co-authored-by: Alex Leites <[email protected]>
Co-authored-by: Alex Leites <[email protected]>
Co-authored-by: Alex Leites <[email protected]>
Co-authored-by: Alex Leites <[email protected]>
Co-authored-by: Alex Leites <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
This PR adds support for TotalRegionalCores errors and makes it more apparent for the customer that this is the root cause of the problem for why their scale up stopped.
This also modifies the code to use a less generic check for subscription level quota errors, and specifically only marking instances as unavailable if we see a SKUFamily quota error instead of just all subscription level quota errors.
We also are only logging the Azure Errors and are returning better customer facing errors in this case since they will be viewed in the nodeclaim.
How was this change tested?
Does this change impact docs?
Release Note