-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle SkuNotAvailable provisioning error #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bryce-Soghigian
previously approved these changes
Nov 22, 2023
tallaxes
commented
Nov 28, 2023
Bryce-Soghigian
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please remove SKUNotAvailable into azure-sdk-for-go-extensions when you get a chance.
Also it might be nice to add some test functions for response errors in extensions as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle
SkuNotAvailable
provisioning error, representing out of capacity for Spot, by taking the SKU out of consideration for 1hr. (In case for some reason this is observed for on-demand - should not happen, see below - it will still defensively take SKU out of consideration, but for 23hrs.)Based on https://aka.ms/azureskunotavailable, it can happen if the SKU is either not available for a location or zone, or out of capacity for Spot. We only expect to observe the Spot case, not location or zone restrictions, because:
How was this change tested?
make presubmit
, manual testing (have not yet observed Spot out-of-capacity)Does this change impact docs?
Release Note