Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle SkuNotAvailable provisioning error #43

Merged
merged 8 commits into from
Nov 28, 2023

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Nov 22, 2023

Description

Handle SkuNotAvailable provisioning error, representing out of capacity for Spot, by taking the SKU out of consideration for 1hr. (In case for some reason this is observed for on-demand - should not happen, see below - it will still defensively take SKU out of consideration, but for 23hrs.)

Based on https://aka.ms/azureskunotavailable, it can happen if the SKU is either not available for a location or zone, or out of capacity for Spot. We only expect to observe the Spot case, not location or zone restrictions, because:

  • SKUs with location restriction are already filtered out via sku.HasLocationRestriction, see fix: support non-zonal regions #35. (Originally SkuNotAvailable was observed prior to this filter).
  • Zonal restrictions are filtered out internally by sku.AvailabilityZones, and don't get offerings

How was this change tested?

  • make presubmit, manual testing (have not yet observed Spot out-of-capacity)

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please remove SKUNotAvailable into azure-sdk-for-go-extensions when you get a chance.

Also it might be nice to add some test functions for response errors in extensions as well.

@tallaxes tallaxes merged commit 61a5891 into main Nov 28, 2023
6 checks passed
@tallaxes tallaxes deleted the tallaxes/skunotavailable branch November 28, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants