test(e2e): fix drift E2E to use ReplaceRequirements #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliedmcb
deleted the
charliedmcb/fixDriftE2EToUseReplaceRequirements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Drift E2E has been a bit flaky with overprovisioning. While investigating I noticed that there was an issue where the drift E2E test was using spot instances:
This should not be the case. We should be using on-demand for drift.
Found there was an issue where we were replacing the Requirements on the nodepool, rather than using the override func.
How was this change tested?
Nothing additional.
*
Does this change impact docs?
Release Note