test(e2e): fix trigger to be built off of the branch, rather than main #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliedmcb
commented
Nov 9, 2023
charliedmcb
changed the title
charliedmcb
changed the title
3 tasks
|
Came up with a new system for handling this, by manually running the existing test matrix on the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
The issue was discovered when testing this PR:
#9
When updating the flow to be indirectly triggered it meant that the suite on the
mainbranch was always the one being run.This meant we didn't have a way of testing new e2e suites, or updates to them.
This PR adds a new trigger that allows us to trigger the E2E suite for the branch instead of
mainI somewhat dislike having both of these triggers, but think its a fine solution for now.
How was this change tested?
See this PR, and the approval comments I used + the linked runs in the checks section.
*
Does this change impact docs?
Release Note