-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removing webhook validation in favor of kubebuilder CRD validation, and removing old SIG Gallery Logic #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test
Seems CI doesnt work from Fork Yet, makes sense, will reopen from branch, or can wait for it to be in place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test
Seems the be lowest priority, we can close and reopen later if its needed |
Pull Request Test Coverage Report for Build 7967579848Details
💛 - Coveralls |
Fixes #
Description
We removed ImageID from the AKSNodeClass API, and plan to add it back in the future, so i want to reduce/remove all validation in the webhooks, so removed here, and added Kubebuilder Validation instead for when we do turn it back on.
How was this change tested?
Temporarily added back in ImageID validated it validated our requests, and removed it again.
Does this change impact docs?
Release Note